server: trim autoscale Windows VM hostname#11327
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11327 +/- ##
=========================================
Coverage 17.56% 17.56%
+ Complexity 15544 15543 -1
=========================================
Files 5909 5909
Lines 529059 529074 +15
Branches 64617 64620 +3
=========================================
+ Hits 92941 92944 +3
- Misses 425664 425675 +11
- Partials 10454 10455 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@blueorangutan package |
|
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14463 |
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
@shwstppr |
|
@weizhouapache yes, though I wanted to confirm if it is a good idea to use the last 15 characters of the long generated name. Not using the first 15 as they can turn out to be the same. |
@shwstppr is it possible the first letter is unaccepted (for example |
server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java
Outdated
Show resolved
Hide resolved
|
@blueorangutan package |
|
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14730 |
server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java
Outdated
Show resolved
Hide resolved
|
@blueorangutan package |
|
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14929 |
|
@blueorangutan test |
|
@shwstppr I am getting this NPE with a Windows10 qcow2 template. Not sure if I did something wrong. 
|
|
@blueorangutan package |
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
weizhouapache
force-pushed
the
fix-autoscalewinvm
branch
from
d24ffc3 to
d2544d4
Compare
|
discussed with @shwstppr , I made some changes on this PR on the name convention of autoscale Windows VM now the vm name and display name look like the last 6 letters are the same in the two names. they are generated by |
|
@blueorangutan package |
|
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15675 |
|
@blueorangutan package |
|
@rosi-shapeblue a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 15990 |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 16003 |
|
@blueorangutan package |
|
@RosiKyu a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 16020 |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 16027 |
|
@blueorangutan package |
|
@RosiKyu a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 16033 |
RosiKyu
left a comment
RosiKyu
left a comment
There was a problem hiding this comment.
LGTM
| Test Case | Expected | Actual | Status |
|---|---|---|---|
| Windows hostname ≤ 15 chars | as-WinVm-xxxxxx | as-WinVm-cifpcf | PASS |
| Windows displayname full | autoScaleVm-...-1-xxxxxx | autoScaleVm-windows-autoscale-test-1-cifpcf | PASS |
| Linux name = displayname | Same value | Both autoScaleVm-linux-autoscale-test-1-pjudpx | PASS |
| No regression for Linux | Full hostname format | Full hostname format | PASS |
Windows VMs
(localcloud) 🐱 > list virtualmachines listall=true keyword=as-WinVm filter=id,name,displayname,state
{
"count": 3,
"virtualmachine": [
{
"displayname": "autoScaleVm-windows-autoscale-test-1-cifpcf",
"id": "b13dd0d8-b424-4d55-979a-797b7cf5040c",
"name": "as-WinVm-cifpcf",
"state": "Running"
},
{
"displayname": "autoScaleVm-windows-autoscale-test-2-xgvxsl",
"id": "0eca7403-7ca9-498f-9eda-7582bb179d6f",
"name": "as-WinVm-xgvxsl",
"state": "Running"
},
{
"displayname": "autoScaleVm-windows-autoscale-test-3-cacjld",
"id": "966ea9c0-a16b-4ff8-9bb6-323660814f95",
"name": "as-WinVm-cacjld",
"state": "Running"
}
]
}
Linux VMs
(localcloud) 🐱 > list virtualmachines listall=true keyword=autoScaleVm-linux filter=id,name,displayname,state
{
"count": 1,
"virtualmachine": [
{
"displayname": "autoScaleVm-linux-autoscale-test-1-pjudpx",
"id": "24a59eb9-d874-4717-aed0-ecda7ecca4b6",
"name": "autoScaleVm-linux-autoscale-test-1-pjudpx",
"state": "Running"
}
]
}
DB Evidence
mysql> SELECT
-> v.id,
-> v.instance_name,
-> v.name AS hostname,
-> v.display_name,
-> v.state,
-> g.display_name AS guest_os
-> FROM vm_instance v
-> LEFT JOIN guest_os g ON v.guest_os_id = g.id
-> WHERE v.display_name LIKE 'autoScaleVm%'
-> ORDER BY v.created DESC;
+----+---------------+-------------------------------------------+---------------------------------------------+---------+------------------------------+
| id | instance_name | hostname | display_name | state | guest_os |
+----+---------------+-------------------------------------------+---------------------------------------------+---------+------------------------------+
| 8 | i-2-8-VM | autoScaleVm-linux-autoscale-test-1-pjudpx | autoScaleVm-linux-autoscale-test-1-pjudpx | Running | CentOS 5.5 (64-bit) |
| 7 | i-2-7-VM | as-WinVm-cacjld | autoScaleVm-windows-autoscale-test-3-cacjld | Running | Windows Server 2019 (64-bit) |
| 6 | i-2-6-VM | as-WinVm-xgvxsl | autoScaleVm-windows-autoscale-test-2-xgvxsl | Running | Windows Server 2019 (64-bit) |
| 5 | i-2-5-VM | as-WinVm-cifpcf | autoScaleVm-windows-autoscale-test-1-cifpcf | Running | Windows Server 2019 (64-bit) |
+----+---------------+-------------------------------------------+---------------------------------------------+---------+------------------------------+
4 rows in set (0.00 sec)
UI Evidence
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> Co-authored-by: Wei Zhou <weizhou@apache.org>
8 participants
Description
Fixes #9505
Trim the generated hostname for Windows VM to 15 characters.
Doc PR: apache/cloudstack-documentation#575
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?